[PATCH] cpufreq: pmac64: Add missing pmf_put_function() calls

Miaoqian Lin linmq006 at gmail.com
Wed Mar 19 00:40:38 AEDT 2025


Fix reference count leak when pmf_find_function() fails for one function,
Add missing pmf_put_function() calls.

Fixes: 9a699aefa87c ("[PATCH] 4/5 powerpc: Add cpufreq support for all desktop G5")
Signed-off-by: Miaoqian Lin <linmq006 at gmail.com>
---
 drivers/cpufreq/pmac64-cpufreq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c
index 74ff6c47df29..9a5a4fca27f0 100644
--- a/drivers/cpufreq/pmac64-cpufreq.c
+++ b/drivers/cpufreq/pmac64-cpufreq.c
@@ -412,6 +412,8 @@ static int __init g5_neo2_cpufreq_init(struct device_node *cpunode)
 		of_node_put(root);
 		if (pfunc_set_vdnap0 == NULL ||
 		    pfunc_vdnap0_complete == NULL) {
+			pmf_put_function(pfunc_set_vdnap0);
+			pmf_put_function(pfunc_vdnap0_complete);
 			pr_err("Can't find required platform function\n");
 			goto bail_noprops;
 		}
-- 
2.39.5 (Apple Git-154)



More information about the Linuxppc-dev mailing list