[PATCH v7 1/7] powerpc/pseries: Define common functions for RTAS sequence calls

[kernel test robot]

Hi Haren,

kernel test robot noticed the following build warnings:

[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes linus/master v6.14-rc6]
[cannot apply to next-20250307]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Haren-Myneni/powerpc-pseries-Define-common-functions-for-RTAS-sequence-calls/20250310-054319
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20250309213916.762116-2-haren%40linux.ibm.com
patch subject: [PATCH v7 1/7] powerpc/pseries: Define common functions for RTAS sequence calls
config: powerpc64-randconfig-r072-20250311 (https://download.01.org/0day-ci/archive/20250311/202503111557.y6cdjLzI-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project e15545cad8297ec7555f26e5ae74a9f0511203e7)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250311/202503111557.y6cdjLzI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503111557.y6cdjLzI-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/powerpc/platforms/pseries/papr-vpd.c:127: warning: Function parameter or struct member 'seq' not described in 'vpd_sequence_begin'
--
>> arch/powerpc/platforms/pseries/papr-rtas-common.c:171: warning: Excess function parameter 'param' description in 'papr_rtas_retrieve'
>> arch/powerpc/platforms/pseries/papr-rtas-common.c:208: warning: Excess function parameter 'param' description in 'papr_rtas_setup_file_interface'
>> arch/powerpc/platforms/pseries/papr-rtas-common.c:255: warning: Function parameter or struct member 'status' not described in 'papr_rtas_sequence_should_stop'
>> arch/powerpc/platforms/pseries/papr-rtas-common.c:255: warning: Function parameter or struct member 'init_state' not described in 'papr_rtas_sequence_should_stop'


vim +127 arch/powerpc/platforms/pseries/papr-vpd.c

514f6ff4369a30b Nathan Lynch 2023-12-12  113  
514f6ff4369a30b Nathan Lynch 2023-12-12  114  /*
514f6ff4369a30b Nathan Lynch 2023-12-12  115   * Internal VPD sequence APIs. A VPD sequence is a series of calls to
514f6ff4369a30b Nathan Lynch 2023-12-12  116   * ibm,get-vpd for a given location code. The sequence ends when an
514f6ff4369a30b Nathan Lynch 2023-12-12  117   * error is encountered or all VPD for the location code has been
514f6ff4369a30b Nathan Lynch 2023-12-12  118   * returned.
514f6ff4369a30b Nathan Lynch 2023-12-12  119   */
514f6ff4369a30b Nathan Lynch 2023-12-12  120  
514f6ff4369a30b Nathan Lynch 2023-12-12  121  /**
514f6ff4369a30b Nathan Lynch 2023-12-12  122   * vpd_sequence_begin() - Begin a VPD retrieval sequence.
514f6ff4369a30b Nathan Lynch 2023-12-12  123   *
514f6ff4369a30b Nathan Lynch 2023-12-12  124   * Context: May sleep.
514f6ff4369a30b Nathan Lynch 2023-12-12  125   */
c657e2672fb8b67 Haren Myneni 2025-03-09  126  static void vpd_sequence_begin(struct papr_rtas_sequence *seq)
514f6ff4369a30b Nathan Lynch 2023-12-12 @127  {
c657e2672fb8b67 Haren Myneni 2025-03-09  128  	struct rtas_ibm_get_vpd_params *vpd_params;
514f6ff4369a30b Nathan Lynch 2023-12-12  129  	/*
514f6ff4369a30b Nathan Lynch 2023-12-12  130  	 * Use a static data structure for the location code passed to
514f6ff4369a30b Nathan Lynch 2023-12-12  131  	 * RTAS to ensure it's in the RMA and avoid a separate work
514f6ff4369a30b Nathan Lynch 2023-12-12  132  	 * area allocation. Guarded by the function lock.
514f6ff4369a30b Nathan Lynch 2023-12-12  133  	 */
514f6ff4369a30b Nathan Lynch 2023-12-12  134  	static struct papr_location_code static_loc_code;
514f6ff4369a30b Nathan Lynch 2023-12-12  135  
c657e2672fb8b67 Haren Myneni 2025-03-09  136  	vpd_params =  (struct rtas_ibm_get_vpd_params *)seq->params;
514f6ff4369a30b Nathan Lynch 2023-12-12  137  	/*
514f6ff4369a30b Nathan Lynch 2023-12-12  138  	 * We could allocate the work area before acquiring the
514f6ff4369a30b Nathan Lynch 2023-12-12  139  	 * function lock, but that would allow concurrent requests to
514f6ff4369a30b Nathan Lynch 2023-12-12  140  	 * exhaust the limited work area pool for no benefit. So
514f6ff4369a30b Nathan Lynch 2023-12-12  141  	 * allocate the work area under the lock.
514f6ff4369a30b Nathan Lynch 2023-12-12  142  	 */
514f6ff4369a30b Nathan Lynch 2023-12-12  143  	mutex_lock(&rtas_ibm_get_vpd_lock);
c657e2672fb8b67 Haren Myneni 2025-03-09  144  	static_loc_code = *(struct papr_location_code *)vpd_params->loc_code;
c657e2672fb8b67 Haren Myneni 2025-03-09  145  	vpd_params =  (struct rtas_ibm_get_vpd_params *)seq->params;
c657e2672fb8b67 Haren Myneni 2025-03-09  146  	vpd_params->work_area = rtas_work_area_alloc(SZ_4K);
c657e2672fb8b67 Haren Myneni 2025-03-09  147  	vpd_params->loc_code = &static_loc_code;
c657e2672fb8b67 Haren Myneni 2025-03-09  148  	vpd_params->sequence = 1;
c657e2672fb8b67 Haren Myneni 2025-03-09  149  	vpd_params->status = 0;
514f6ff4369a30b Nathan Lynch 2023-12-12  150  }
514f6ff4369a30b Nathan Lynch 2023-12-12  151  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki