[PATCH] soc: Use dev_fwnode()
Christophe Leroy
christophe.leroy at csgroup.eu
Tue Jul 8 18:33:29 AEST 2025
Hi,
Le 11/06/2025 à 12:43, Jiri Slaby (SUSE) a écrit :
> irq_domain_create_simple() takes fwnode as the first argument. It can be
> extracted from the struct device using dev_fwnode() helper instead of
> using of_node with of_fwnode_handle().
>
> So use the dev_fwnode() helper.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby at kernel.org>
> Cc: Qiang Zhao <qiang.zhao at nxp.com>
> Cc: Christophe Leroy <christophe.leroy at csgroup.eu>
> Cc: Thierry Reding <thierry.reding at gmail.com>
> Cc: Jonathan Hunter <jonathanh at nvidia.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linuxppc-dev at lists.ozlabs.org
There must be something wrong with this patch. b4 shazam applies a
different patch.
$ b4 shazam -l -s --single-message --no-parent
20250611104348.192092-19-jirislaby at kernel.org
Single-message mode, ignoring any follow-ups
Grabbing thread from
lore.kernel.org/all/20250611104348.192092-19-jirislaby at kernel.org/t.mbox.gz
Breaking thread to remove parents of
20250611104348.192092-19-jirislaby at kernel.org
Checking for newer revisions
Grabbing search results from lore.kernel.org
Added from v2: 1 patches
Analyzing 25 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 22 code-review messages
Will use the latest revision: v2
You can pick other revisions using the -vN flag
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v2] iio: adc: stm32-adc: Use dev_fwnode()
+ Reviewed-by: David Lechner <dlechner at baylibre.com> (✗
DKIM/baylibre-com.20230601.gappssmtp.com)
+ Link:
https://lore.kernel.org/r/20250612084627.217341-1-jirislaby@kernel.org
+ Signed-off-by: Christophe Leroy <christophe.leroy at csgroup.eu>
---
✓ Signed: DKIM/kernel.org
---
Total patches: 1
---
Application de iio: adc: stm32-adc: Use dev_fwnode()
You must have posted another patch with the same message ID. I had to
apply it manually.
Christophe
>
> ---
> Cc: linux-tegra at vger.kernel.org
> ---
> drivers/soc/fsl/qe/qe_ic.c | 3 +--
> drivers/soc/tegra/pmc.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
> index 4068b501a3a3..943911053af6 100644
> --- a/drivers/soc/fsl/qe/qe_ic.c
> +++ b/drivers/soc/fsl/qe/qe_ic.c
> @@ -407,7 +407,6 @@ static int qe_ic_init(struct platform_device *pdev)
> void (*high_handler)(struct irq_desc *desc);
> struct qe_ic *qe_ic;
> struct resource *res;
> - struct device_node *node = pdev->dev.of_node;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (res == NULL) {
> @@ -441,7 +440,7 @@ static int qe_ic_init(struct platform_device *pdev)
> high_handler = NULL;
> }
>
> - qe_ic->irqhost = irq_domain_create_linear(of_fwnode_handle(node), NR_QE_IC_INTS,
> + qe_ic->irqhost = irq_domain_create_linear(dev_fwnode(&pdev->dev), NR_QE_IC_INTS,
> &qe_ic_host_ops, qe_ic);
> if (qe_ic->irqhost == NULL) {
> dev_err(dev, "failed to add irq domain\n");
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index e0d67bfe955c..9543bee0c321 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -2500,8 +2500,7 @@ static int tegra_pmc_irq_init(struct tegra_pmc *pmc)
> pmc->irq.irq_set_type = pmc->soc->irq_set_type;
> pmc->irq.irq_set_wake = pmc->soc->irq_set_wake;
>
> - pmc->domain = irq_domain_create_hierarchy(parent, 0, 96,
> - of_fwnode_handle(pmc->dev->of_node),
> + pmc->domain = irq_domain_create_hierarchy(parent, 0, 96, dev_fwnode(pmc->dev),
> &tegra_pmc_irq_domain_ops, pmc);
> if (!pmc->domain) {
> dev_err(pmc->dev, "failed to allocate domain\n");
More information about the Linuxppc-dev
mailing list