[PATCH v3 1/2] powerpc/fadump: allocate memory for additional parameters early

Christophe Leroy christophe.leroy at csgroup.eu
Fri Jan 17 23:46:06 AEDT 2025



Le 17/01/2025 à 13:32, Sourabh Jain a écrit :
> Hello Christophe,
> 
> On 17/01/25 17:43, Christophe Leroy wrote:
>>
>>
>> Le 13/11/2024 à 08:06, Sourabh Jain a écrit :
>>> From: Hari Bathini <hbathini at linux.ibm.com>
>>>
>>> Memory for passing additional parameters to fadump capture kernel
>>> is allocated during subsys_initcall level, using memblock. But
>>> as slab is already available by this time, allocation happens via
>>> the buddy allocator. This may work for radix MMU but is likely to
>>> fail in most cases for hash MMU as hash MMU needs this memory in
>>> the first memory block for it to be accessible in real mode in the
>>> capture kernel (second boot). So, allocate memory for additional
>>> parameters area as soon as MMU mode is obvious.
>>>
>>> Fixes: 683eab94da75 ("powerpc/fadump: setup additional parameters for 
>>> dump capture kernel")
>>> Reported-by: Venkat Rao Bagalkote <venkat88 at linux.vnet.ibm.com>
>>> Closes: https://eur01.safelinks.protection.outlook.com/? 
>>> url=https%3A%2F%2Flore.kernel.org%2Flkml%2Fa70e4064- 
>>> a040-447b-8556-1fd02f19383d%40linux.vnet.ibm.com%2FT%2F%23u&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C9df078759a2c42b044cf08dd36f3183b%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638727139896068824%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=iZfkQKw4wJAvwAj%2BbGOS5kcrVtAg8xg%2FFl6ojEYZ6ls%3D&reserved=0
>>> Cc: Mahesh Salgaonkar <mahesh at linux.ibm.com>
>>> Cc: Michael Ellerman <mpe at ellerman.id.au>
>>> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list at gmail.com>
>>> Signed-off-by: Hari Bathini <hbathini at linux.ibm.com>
>>> Signed-off-by: Sourabh Jain <sourabhjain at linux.ibm.com>
>>
>> Version v2 of this series was applied.
>>
>> If needed, can you rebase this patch ?
>>
> Sorry, I didn't get that. Rebase on top of which tree/branch?

I meant on top of any tree including the applied version.

> 
> FYI, there was no functional change from v2 to v3. Only a
> "Reviewed-by" tag was added.

Then I guess there is nothing to do.

Christophe



More information about the Linuxppc-dev mailing list