[PATCH] bus: fsl-mc: fix an error handling in fsl_mc_device_add()

Haoxiang Li lihaoxiang at isrc.iscas.ac.cn
Wed Dec 24 21:52:40 AEDT 2025


On Wed, 24 Dec 2025 10:57:52 +0100, Christophe Leroy wrote:
> Ok, then this needs to be said in the commit message.

I will add it in the patch v2.

> By the way I'm a bit puzzled by the device_add() doc versus the 
> put_device(), because it looks like device_add() already calls 
> put_device() in its error path, see 
> https://elixir.bootlin.com/linux/v6.19-rc2/source/drivers/base/core.c#L3716

I think this is because device_add() increment the reference in the
beginning, see
https://elixir.bootlin.com/linux/v6.19-rc2/source/drivers/base/core.c#L3580
and if device_add() fails, another put_device() should be called to decrement
the reference which is obtained by device_initialize().

Thanks,
Haoxiang Li



More information about the Linuxppc-dev mailing list