[RFC 3/8] book3s64/hash: Fix phys_addr_t printf format in htab_initialize()
Christophe Leroy
christophe.leroy at csgroup.eu
Sat Aug 30 16:26:33 AEST 2025
Le 30/08/2025 à 05:51, Ritesh Harjani (IBM) a écrit :
> We get below errors when we try to enable debug logs in book3s64/hash_utils.c
> This patch fixes these errors related to phys_addr_t printf format.
>
> arch/powerpc/mm/book3s64/hash_utils.c: In function ‘htab_initialize’:
> arch/powerpc/mm/book3s64/hash_utils.c:1401:21: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘phys_addr_t’ {aka ‘long long unsigned int’} [-Werror=format=]
> 1401 | DBG("creating mapping for region: %lx..%lx (prot: %lx)\n",
> arch/powerpc/mm/book3s64/hash_utils.c:1401:21: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘phys_addr_t’ {aka ‘long long unsigned int’} [-Werror=format=]
> cc1: all warnings being treated as errors
> make[6]: *** [../scripts/Makefile.build:287: arch/powerpc/mm/book3s64/hash_utils.o] Error 1
>
> Cc: Madhavan Srinivasan <maddy at linux.ibm.com>
> Cc: Michael Ellerman <mpe at ellerman.id.au>
> Cc: Nicholas Piggin <npiggin at gmail.com>
> Cc: Christophe Leroy <christophe.leroy at csgroup.eu>
> Cc: Paul Mackerras <paulus at ozlabs.org>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar at kernel.org>
> Cc: Donet Tom <donettom at linux.ibm.com>
> Cc: linuxppc-dev at lists.ozlabs.org
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list at gmail.com>
> ---
> arch/powerpc/mm/book3s64/hash_utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/book3s64/hash_utils.c b/arch/powerpc/mm/book3s64/hash_utils.c
> index 1e062056cfb8..495b6da6f5d4 100644
> --- a/arch/powerpc/mm/book3s64/hash_utils.c
> +++ b/arch/powerpc/mm/book3s64/hash_utils.c
> @@ -1394,7 +1394,7 @@ static void __init htab_initialize(void)
> size = end - base;
> base = (unsigned long)__va(base);
>
> - DBG("creating mapping for region: %lx..%lx (prot: %lx)\n",
> + DBG("creating mapping for region: %llx..%llx (prot: %lx)\n",
Use %pa
See
https://docs.kernel.org/core-api/printk-formats.html#physical-address-types-phys-addr-t
> base, size, prot);
>
> if ((base + size) >= H_VMALLOC_START) {
> --
> 2.50.1
>
More information about the Linuxppc-dev
mailing list