[PATCH] mm/numa: Rename memory_add_physaddr_to_nid to memory_get_phys_to_nid
Pratyush Brahma
pratyush.brahma at oss.qualcomm.com
Mon Aug 18 18:27:41 AEST 2025
On Mon, Aug 18, 2025 at 12:29 PM David Hildenbrand <david at redhat.com> wrote:
>
> On 18.08.25 08:41, pratyush.brahma at oss.qualcomm.com wrote:
> > From: Pratyush Brahma <pratyush.brahma at oss.qualcomm.com>
> >
> > The function `memory_add_physaddr_to_nid` seems a misnomer.
> > It does not to "add" a physical address to a NID mapping,
> > but rather it gets the NID associated with a given physical address.
>
> You probably misunderstood what the function is used for: memory hotplug
> aka "memory_add".
Thanks for your feedback. I get the part about memory hotplug here but
using memory_add still seems a little odd as it doesn't truly reflect
what this api is doing.
However, I agree that my current suggestion
may not be the perfect choice for the name, so I'm open to suggestions.
Perhaps, something like "memory_add_get_nid_by_phys" may work here?
>
> This patch is making matters worse by stripping that detail, unfortunately.
>
>
> --
> Cheers
>
> David / dhildenb
>
Thanks and Regards
Pratyush
More information about the Linuxppc-dev
mailing list