[PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work
Sebastian Andrzej Siewior
bigeasy at linutronix.de
Sat Apr 26 02:23:31 AEST 2025
On 2025-04-25 19:54:56 [+0530], Shrikanth Hegde wrote:
> > > But looking at the semantics of usage of xfer_to_guest_mode_work
> > > I think using schedule is probably right over here.
> > > Correct me if i got it all wrong.
> >
> > No, if you do xfer_to_guest_mode_work() then it will invoke schedule()
> > when appropriate. It just the thing in kvmhv_run_single_vcpu() looks odd
> > and might have been duct tape or an accident and could probably be
> > removed.
> >
>
> I was wondering xfer_to_guest_mode_work could also call cond_resched
> instead of schedule since for preempt=full/lazy is preemptible
> as early as possible right?
No, I think it is okay. For preempt=full you shouldn't observe the
flag in xfer_to_guest_mode_work() so it does not matter.
Sebastian
More information about the Linuxppc-dev
mailing list