[PATCH] powerpc: Switch back to struct platform_driver::remove()

Vaibhav Jain vaibhav at linux.ibm.com
Wed Sep 11 20:37:34 AEST 2024


Uwe Kleine-König <u.kleine-koenig at baylibre.com> writes:

> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all pwm drivers to use .remove(), with the eventual goal to drop
> struct platform_driver::remove_new(). As .remove() and .remove_new() have
> the same prototypes, conversion is done by just changing the structure
> member name in the driver initializer.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at baylibre.com>
> ---
>  arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 2 +-
>  arch/powerpc/platforms/85xx/sgy_cts1000.c     | 2 +-
>  arch/powerpc/platforms/pasemi/gpio_mdio.c     | 2 +-
>  arch/powerpc/platforms/powernv/opal-prd.c     | 2 +-
>  arch/powerpc/platforms/pseries/papr_scm.c     | 2 +-
>  arch/powerpc/sysdev/fsl_msi.c                 | 2 +-
>  arch/powerpc/sysdev/pmi.c                     | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
<snip>

>
>  
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index f6a70bc92e83..d95e03b3d3e3 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -1509,7 +1509,7 @@ static const struct of_device_id papr_scm_match[] = {
>  
>  static struct platform_driver papr_scm_driver = {
>  	.probe = papr_scm_probe,
> -	.remove_new = papr_scm_remove,
> +	.remove = papr_scm_remove,
>  	.driver = {
>  		.name = "papr_scm",
>  		.of_match_table = papr_scm_match,
> diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
> index e205135ae1fe..1aa0cb097c9c 100644
> --- a/arch/powerpc/sysdev/fsl_msi.c
> +++ b/arch/powerpc/sysdev/fsl_msi.c
> @@ -603,7 +603,7 @@ static struct platform_driver fsl_of_msi_driver = {
>  		.of_match_table = fsl_of_msi_ids,
>  	},
>  	.probe = fsl_of_msi_probe,
> -	.remove_new = fsl_of_msi_remove,
> +	.remove = fsl_of_msi_remove,
>  };
<snip>

Dont have any objections to changes in arch/powerpc/platforms/pseries/papr_scm.c

Reviewed-by: Vaibhav Jain <vaibhav at linux.ibm.com>



-- 
Cheers
~ Vaibhav


More information about the Linuxppc-dev mailing list