[PATCH -next] powerpc/machdep: Remove duplicated include in svm.c
Michael Ellerman
mpe at ellerman.id.au
Fri Nov 8 10:49:44 AEDT 2024
Christophe Leroy <christophe.leroy at csgroup.eu> writes:
> Le 07/11/2024 à 12:29, Michael Ellerman a écrit :
>> Yang Li <yang.lee at linux.alibaba.com> writes:
>>> The header files linux/mem_encrypt.h is included twice in svm.c,
>>> so one inclusion of each can be removed.
>>>
>>> Reported-by: Abaci Robot <abaci at linux.alibaba.com>
>>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11750
>>> Signed-off-by: Yang Li <yang.lee at linux.alibaba.com>
>>> ---
>>> arch/powerpc/platforms/pseries/svm.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>
>> The two includes only appear in linux-next, and they both come from
>> different trees. They are required in each tree to avoid breaking the
>> build.
>>
>> So no one can merge this patch until the two trees are merged into mainline.
>
> But can't those two trees coordinate the patches so that the include
> goes at the same place avoiding duplication at merge ?
Yes that would work.
Except that in this case it's too late because the commits have already
been applied to both trees for over a week - neither maintainer is going
to want to rebase for something trivial like a duplicated header.
I could apply a patch to my tree to move the include to the same line as
the commit in the DMA tree, but even that seems like overkill for a
duplicated header.
I'll try and remember to apply this once the trees are merged in
mainline. But if not the bot that detected it in the first place can
just detect it again and repost.
cheers
More information about the Linuxppc-dev
mailing list