[PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage
Geoff Levand
geoff at infradead.org
Thu Mar 21 20:32:25 AEDT 2024
Hi Geert,
On 3/21/24 17:32, Geert Uytterhoeven wrote:
>> static int ps3_probe_thread(void *data)
>> {
>> - struct ps3_notification_device dev;
>> + static struct ps3_notification_device dev;
>> int res;
>> unsigned int irq;
>> u64 lpar;
>
> Making it static increases kernel size for everyone. So I'd rather
> allocate it dynamically. The thread already allocates a buffer, which
> can be replaced at no cost by allocating a structure containing both
> the ps3_notification_device and the buffer.
This seems like a much better solution.
-Geoff
More information about the Linuxppc-dev
mailing list