[PATCH v6 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support

Herve Codina herve.codina at bootlin.com
Thu Mar 7 18:26:46 AEDT 2024


Hi Yury,

On Wed, 6 Mar 2024 05:06:12 -0800
Yury Norov <yury.norov at gmail.com> wrote:

...
> > +static int qmc_hdlc_xlate_ts_info(struct qmc_hdlc *qmc_hdlc,
> > +				  const struct qmc_chan_ts_info *ts_info, u32 *slot_map)
> > +{
> > +	DECLARE_BITMAP(ts_mask_avail, 64);
> > +	DECLARE_BITMAP(ts_mask, 64);
> > +	DECLARE_BITMAP(map, 64);
> > +	u32 array32[2];  
> 
> NIT. Bad name. I'd suggest slot_array, or something.
> 

A new iteration of this series is planned.
I will change to slot_array as suggested.

Best regards,
Hervé


More information about the Linuxppc-dev mailing list