[PATCH 25/42] drivers/scsi/ibmvscsi: Convert snprintf to sysfs_emit

Tyrel Datwyler tyreld at linux.ibm.com
Wed Jan 17 08:38:46 AEDT 2024


On 1/15/24 20:51, Li Zhijian wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
> 
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
> 
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3493:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3503:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3513:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3522:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3530:8-16: WARNING: please use sysfs_emit
> 
> No functional change intended
> 
> CC: Tyrel Datwyler <tyreld at linux.ibm.com>
> CC: Michael Ellerman <mpe at ellerman.id.au>
> CC: Nicholas Piggin <npiggin at gmail.com>
> CC: Christophe Leroy <christophe.leroy at csgroup.eu>
> CC: "Aneesh Kumar K.V" <aneesh.kumar at kernel.org>
> CC: "Naveen N. Rao" <naveen.n.rao at linux.ibm.com>
> CC: "James E.J. Bottomley" <jejb at linux.ibm.com>
> CC: "Martin K. Petersen" <martin.petersen at oracle.com>
> CC: linux-scsi at vger.kernel.org
> CC: linuxppc-dev at lists.ozlabs.org
> Signed-off-by: Li Zhijian <lizhijian at fujitsu.com>
> ---

Acked-by: Tyrel Datwyler <tyreld at linux.ibm.com>



More information about the Linuxppc-dev mailing list