[RFC PATCH] selftest/powerpc: Add rule file to address sub-folder test fail

Sachin Sant sachinp at linux.ibm.com
Tue Feb 27 23:38:24 AEDT 2024



> On 25-Feb-2024, at 10:09 PM, Madhavan Srinivasan <maddy at linux.ibm.com> wrote:
> 
> When running `make -C powerpc/pmu run_tests` from top level selftests
> directory, currently this error is being reported
> 
> make: Entering directory '/home/maddy/linux/tools/testing/selftests/powerpc/pmu'
> Makefile:40: warning: overriding recipe for target 'emit_tests'
> ../../lib.mk:111: warning: ignoring old recipe for target 'emit_tests'
> gcc -m64    count_instructions.c ../harness.c event.c lib.c ../utils.c loop.S  -o /home/maddy/selftest_output//count_instructions
> In file included from count_instructions.c:13:
> event.h:12:10: fatal error: utils.h: No such file or directory
>   12 | #include "utils.h"
>      |          ^~~~~~~~~
> compilation terminated.
> 
> This is due to missing of include path in CFLAGS. That is, CFLAGS and
> GIT_VERSION macros are defined in the powerpc/ folder Makefile which
> in this case not involved.
> 
> To address the failure incase of executing specific sub-folder test directly,
> a new rule file has been addded by the patch called "include.mk" under
> selftest/powerpc/ folder and is linked to all Makefile of powerpc/pmu
> sub-folders.
> 
> Signed-off-by: Madhavan Srinivasan <maddy at linux.ibm.com>
> ---

Thanks for the fix Maddy. The patch fixes the reported problem
for me.

— Sachin



More information about the Linuxppc-dev mailing list