[kvm-unit-tests PATCH 29/32] configure: Fail on unknown arch
Nicholas Piggin
npiggin at gmail.com
Mon Feb 26 21:12:15 AEDT 2024
configure will accept an unknown arch, and if it is the name of a
directory in the source tree the command will silently succeed. Make
it only accept supported arch names.
Also print the full path of a missing test directory to disambiguate
the error in out of tree builds.
Cc: Alexandru Elisei <alexandru.elisei at arm.com>
Cc: Andrew Jones <andrew.jones at linux.dev>
Cc: Claudio Imbrenda <imbrenda at linux.ibm.com>
Cc: David Hildenbrand <david at redhat.com>
Cc: Eric Auger <eric.auger at redhat.com>
Cc: Janosch Frank <frankja at linux.ibm.com>
Cc: Laurent Vivier <lvivier at redhat.com>
Cc: Nico Böhr <nrb at linux.ibm.com>
Cc: Paolo Bonzini <pbonzini at redhat.com>
Cc: Thomas Huth <thuth at redhat.com>
Cc: kvm at vger.kernel.org
Cc: linux-s390 at vger.kernel.org
Cc: kvmarm at lists.linux.dev
Cc: kvm-riscv at lists.infradead.org
Cc: linuxppc-dev at lists.ozlabs.org
Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
configure | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 6907ccbbb..ae522c556 100755
--- a/configure
+++ b/configure
@@ -45,7 +45,8 @@ usage() {
Usage: $0 [options]
Options include:
- --arch=ARCH architecture to compile for ($arch)
+ --arch=ARCH architecture to compile for ($arch). ARCH can be one of:
+ arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64
--processor=PROCESSOR processor to compile for ($arch)
--target=TARGET target platform that the tests will be running on (qemu or
kvmtool, default is qemu) (arm/arm64 only)
@@ -321,11 +322,15 @@ elif [ "$arch" = "ppc64" ]; then
elif [ "$arch" = "riscv32" ] || [ "$arch" = "riscv64" ]; then
testdir=riscv
arch_libdir=riscv
+elif [ "$arch" = "s390x" ]; then
+ testdir=s390x
else
- testdir=$arch
+ echo "arch $arch is not supported!"
+ arch=
+ usage
fi
if [ ! -d "$srcdir/$testdir" ]; then
- echo "$testdir does not exist!"
+ echo "$srcdir/$testdir does not exist!"
exit 1
fi
--
2.42.0
More information about the Linuxppc-dev
mailing list