[PATCH] drivers/ps3: select VIDEO to provide cmdline functions

Geoff Levand geoff at infradead.org
Wed Feb 7 18:31:32 AEDT 2024


Hi,

On 2/7/24 12:37, Randy Dunlap wrote:
> When VIDEO is not set, there is a build error. Fix that by selecting
> VIDEO for PS3_PS3AV.
> 
> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
> 
> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Michael Ellerman <mpe at ellerman.id.au>
> Cc: Nicholas Piggin <npiggin at gmail.com>
> Cc: Christophe Leroy <christophe.leroy at csgroup.eu>
> Cc: Aneesh Kumar K.V <aneesh.kumar at kernel.org>
> Cc: Naveen N. Rao <naveen.n.rao at linux.ibm.com>
> Cc: linuxppc-dev at lists.ozlabs.org
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Geoff Levand <geoff at infradead.org>
> ---
>  arch/powerpc/platforms/ps3/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig
> --- a/arch/powerpc/platforms/ps3/Kconfig
> +++ b/arch/powerpc/platforms/ps3/Kconfig
> @@ -67,6 +67,7 @@ config PS3_VUART
>  config PS3_PS3AV
>  	depends on PPC_PS3
>  	tristate "PS3 AV settings driver" if PS3_ADVANCED
> +	select VIDEO
>  	select PS3_VUART
>  	default y
>  	help

Seems good.

Acked-by: Geoff Levand <geoff at infradead.org>




More information about the Linuxppc-dev mailing list