[PATCH 06/19] soc/qman: test: Use kthread_run_on_cpu()
LEROY Christophe
christophe.leroy2 at cs-soprasteria.com
Fri Dec 13 18:27:03 AEDT 2024
Le 11/12/2024 à 16:40, Frederic Weisbecker a écrit :
> Use the proper API instead of open coding it.
>
> However it looks like kthreads here could be replaced by the use of a
> per-cpu workqueue instead.
>
> Signed-off-by: Frederic Weisbecker <frederic at kernel.org>
Acked-by: Christophe Leroy <christophe.leroy at csgroup.eu>
> ---
> drivers/soc/fsl/qbman/qman_test_stash.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/fsl/qbman/qman_test_stash.c b/drivers/soc/fsl/qbman/qman_test_stash.c
> index b7e8e5ec884c..f4d3c2146f4f 100644
> --- a/drivers/soc/fsl/qbman/qman_test_stash.c
> +++ b/drivers/soc/fsl/qbman/qman_test_stash.c
> @@ -108,14 +108,12 @@ static int on_all_cpus(int (*fn)(void))
> .fn = fn,
> .started = ATOMIC_INIT(0)
> };
> - struct task_struct *k = kthread_create(bstrap_fn, &bstrap,
> - "hotpotato%d", cpu);
> + struct task_struct *k = kthread_run_on_cpu(bstrap_fn, &bstrap,
> + cpu, "hotpotato%d");
> int ret;
>
> if (IS_ERR(k))
> return -ENOMEM;
> - kthread_bind(k, cpu);
> - wake_up_process(k);
> /*
> * If we call kthread_stop() before the "wake up" has had an
> * effect, then the thread may exit with -EINTR without ever
More information about the Linuxppc-dev
mailing list