[PATCH] powerpc/476: Drop explicit initialization of struct i2c_device_id::driver_data to 0

[Christophe Leroy]

Le 04/08/2024 à 13:20, Uwe Kleine-König a écrit :
> This driver doesn't use the driver_data member of struct i2c_device_id,
> so don't explicitly initialize this member.

Well, even if the member was used, a 0 init is useless because as soon 
as you initialise one field of the struct, the compiler initialise 
everything else with 0.

> 
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named designators. But it's also a nice
> cleanup on its own.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at baylibre.com>

Reviewed-by: Christophe Leroy <christophe leroy at csgroup.eu>

> ---
>   arch/powerpc/platforms/44x/ppc476.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/44x/ppc476.c b/arch/powerpc/platforms/44x/ppc476.c
> index 164cbcd4588e..e7b7bdaad341 100644
> --- a/arch/powerpc/platforms/44x/ppc476.c
> +++ b/arch/powerpc/platforms/44x/ppc476.c
> @@ -95,7 +95,7 @@ static int avr_probe(struct i2c_client *client)
>   }
>   
>   static const struct i2c_device_id avr_id[] = {
> -	{ "akebono-avr", 0 },
> +	{ "akebono-avr" },
>   	{ }
>   };
>   
> 
> base-commit: f524a5e4dfb75b277c9a5ad819ca5f035f490f14