[PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup

Andi Shyti andi.shyti at kernel.org
Wed Apr 17 00:07:43 AEST 2024


Hi Chris,

On Tue, Apr 16, 2024 at 03:59:13AM +0000, Chris Packham wrote:
> On 16/04/24 08:54, Andi Shyti wrote:
> >>   	/* Enable I2C interrupts for mpc5121 */
> >> -	node_ctrl = of_find_compatible_node(NULL, NULL,
> >> -					    "fsl,mpc5121-i2c-ctrl");
> >> +	struct device_node *node_ctrl __free(device_node) =
> > How have you tested this?
> 
> I'm not sure I know anyone that still has a mpc5121. Maybe someone on 
> linuxppc-dev?

that's why I was asking, this would be the first driver in i2c
using Rob's __free(device_node).

> I did try to take the patch for a spin on my T2081RDB but I'm having 
> some userland issues on it for some reason (unrelated to this change). 
> The kernel boot does discover a few peripherals hanging of the I2C 
> interface but I'm not in a position to offer up a Tested-by and I've run 
> out of time to debug why my board is unhappy.

Thanks for giving it a try.

Andi


More information about the Linuxppc-dev mailing list