[0/2] powerpc/powernv/vas: Adjustments for two function implementations
Michael Ellerman
mpe at ellerman.id.au
Tue Apr 16 21:11:15 AEST 2024
Markus Elfring <Markus.Elfring at web.de> writes:
>> A few update suggestions were taken into account
>> from static source code analysis.
>>
>> Markus Elfring (2):
>
> I would appreciate a bit more information about the reasons
> why this patch series was rejected.
>
>
>> One function call less in vas_window_alloc() after error detection
>
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/1f1c21cf-c34c-418c-b00c-8e6474f12612@web.de/
It introduced a new goto and label to avoid a kfree(NULL) call, but
kfree() explicitly accepts NULL and handles it. So it complicates the
source code for no gain.
>> Return directly after a failed kasprintf() in map_paste_region()
>
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/f46f04bc-613c-4e98-b602-4c5120556b09@web.de/
Basically the same reasoning. And it also changes the function from
having two return paths (success and error), to three.
cheers
More information about the Linuxppc-dev
mailing list