[PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler

Justin Stitt justinstitt at google.com
Sat Apr 6 06:57:41 AEDT 2024


On Fri, Apr 5, 2024 at 12:31 PM Nathan Chancellor <nathan at kernel.org> wrote:
>
> When building with LLVM_IAS=1, there is an error because
> '-fatal-warnings' is not recognized as a valid flag:
>
>   clang: error: unsupported argument '-fatal-warnings' to option '-Wa,'
>
> Use the double hyphen version of the flag, '--fatal-warnings', which
> works with both the GNU assembler and LLVM's integrated assembler.
>
> Fixes: 608d4a5ca563 ("powerpc: Error on assembly warnings")
> Signed-off-by: Nathan Chancellor <nathan at kernel.org>

Nice catch.

Reviewed-by: Justin Stitt <justinstitt at google.com>

> ---
>  arch/powerpc/Kbuild | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/Kbuild b/arch/powerpc/Kbuild
> index da862e9558bc..571f260b0842 100644
> --- a/arch/powerpc/Kbuild
> +++ b/arch/powerpc/Kbuild
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
> -subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror -Wa,-fatal-warnings
> -subdir-asflags-$(CONFIG_PPC_WERROR) := -Wa,-fatal-warnings
> +subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror -Wa,--fatal-warnings
> +subdir-asflags-$(CONFIG_PPC_WERROR) := -Wa,--fatal-warnings
>
>  obj-y += kernel/
>  obj-y += mm/
>
> ---
> base-commit: bfe51886ca544956eb4ff924d1937ac01d0ca9c8
> change-id: 20240405-ppc-fix-wa-fatal-warnings-clang-603f0ebb0133
>
> Best regards,
> --
> Nathan Chancellor <nathan at kernel.org>
>


More information about the Linuxppc-dev mailing list