[PATCH v3] scsi: sg: Avoid race in error handling & drop bogus warn

[Sachin Sant]

> On 2 Apr 2024, at 12:40 AM, Alexander Wetzel <Alexander at wetzel-home.de> wrote:
> 
> commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
> introduced an incorrect WARN_ON_ONCE() and missed a sequence where
> sg_device_destroy() was used after scsi_device_put().
> 
> sg_device_destroy() is accessing the parent scsi_device request_queue which
> will already be set to NULL when the preceding call to scsi_device_put()
> removed the last reference to the parent scsi_device.
> 
> Drop the incorrect WARN_ON_ONCE() - allowing more than one concurrent
> access to the sg device - and make sure sg_device_destroy() is not used
> after scsi_device_put() in the error handling.
> 
> Link: https://lore.kernel.org/all/5375B275-D137-4D5F-BE25-6AF8ACAE41EF@linux.ibm.com
> Fixes: 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
> Cc: stable at vger.kernel.org
> Signed-off-by: Alexander Wetzel <Alexander at wetzel-home.de>
> ---

Thanks for the fix. I tested this patch and confirm it fixes the reported problem.

Tested-by: Sachin Sant <sachinp at linux.ibm.com>


— Sachin