[PATCH] powerpc: add `cur_cpu_spec` symbol to vmcoreinfo

Hari Bathini hbathini at linux.ibm.com
Fri Sep 15 16:15:43 AEST 2023



On 14/09/23 6:52 pm, Michael Ellerman wrote:
> Aditya Gupta <adityag at linux.ibm.com> writes:
>> Presently, while reading a vmcore, makedumpfile uses
>> `cur_cpu_spec.mmu_features` to decide whether the crashed system had
>> RADIX MMU or not.
>>
>> Currently, makedumpfile fails to get the `cur_cpu_spec` symbol (unless
>> a vmlinux is passed with the `-x` flag to makedumpfile), and hence
>> assigns offsets and shifts (such as pgd_offset_l4) incorrecly considering
>> MMU to be hash MMU.
>>
>> Add `cur_cpu_spec` symbol and offset of `mmu_features` in the
>> `cpu_spec` struct, to VMCOREINFO, so that the symbol address and offset
>> is accessible to makedumpfile, without needing the vmlinux file
> 
> This looks fine.
> 
> Seems like cpu_features would be needed or at least pretty useful too?

Yeah. Would be nice to have access to that, to accurately identify the
kind of system vmcore was generated for.

Thanks
Hari


More information about the Linuxppc-dev mailing list