[PATCH V2] perf test: Fix parse-events tests to skip parametrized events

Athira Rajeev atrajeev at linux.vnet.ibm.com
Sat Sep 9 00:18:33 AEST 2023



> On 08-Sep-2023, at 11:04 AM, Sachin Sant <sachinp at linux.ibm.com> wrote:
> 
> 
> 
>> On 07-Sep-2023, at 10:29 PM, Athira Rajeev <atrajeev at linux.vnet.ibm.com> wrote:
>> 
>> Testcase "Parsing of all PMU events from sysfs" parse events for
>> all PMUs, and not just cpu. In case of powerpc, the PowerVM
>> environment supports events from hv_24x7 and hv_gpci PMU which
>> is of example format like below:
>> 
>> - hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
>> - hv_gpci/event,partition_id=?/
>> 
>> The value for "?" needs to be filled in depending on system
>> configuration. It is better to skip these parametrized events
>> in this test as it is done in:
>> 'commit b50d691e50e6 ("perf test: Fix "all PMU test" to skip
>> parametrized events")' which handled a simialr instance with
>> "all PMU test".
>> 
>> Fix parse-events test to skip parametrized events since
>> it needs proper setup of the parameters.
>> 
>> Signed-off-by: Athira Rajeev <atrajeev at linux.vnet.ibm.com>
>> ---
>> Changelog:
>> v1 -> v2:
>> Addressed review comments from Ian. Updated size of
>> pmu event name variable and changed bool name which is
>> used to skip the test.
>> 
> 
> The patch fixes the reported issue.
> 
> 6.2: Parsing of all PMU events from sysfs                          : Ok
> 6.3: Parsing of given PMU events from sysfs                        : Ok
> 
> Tested-by: Sachin Sant <sachinp at linux.ibm.com>
> 
> - Sachin

Hi Sachin, Ian

Thanks for testing the patch

Athira




More information about the Linuxppc-dev mailing list