[PATCH v2] mtd: powernv_flash: check return value of devm_kasprintf()
Yi Yang
yiyang13 at huawei.com
Thu Oct 19 12:30:50 AEDT 2023
devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful by
checking the pointer validity.
Fixes: acfe63ec1c59 ("mtd: Convert to using %pOFn instead of device_node.name")
Signed-off-by: Yi Yang <yiyang13 at huawei.com>
---
drivers/mtd/devices/powernv_flash.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c
index 66044f4f5bad..956a79c739e5 100644
--- a/drivers/mtd/devices/powernv_flash.c
+++ b/drivers/mtd/devices/powernv_flash.c
@@ -207,6 +207,10 @@ static int powernv_flash_set_driver_info(struct device *dev,
* get them
*/
mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%pOFP", dev->of_node);
+ if (!mtd->name) {
+ dev_err(dev, "failed to allocate mtd->name\n");
+ return -ENOMEM;
+ }
mtd->type = MTD_NORFLASH;
mtd->flags = MTD_WRITEABLE;
mtd->size = size;
--
2.25.1
More information about the Linuxppc-dev
mailing list