[PATCH 06/20] mtd: powernv_flash: Convert to platform remove callback returning void

Miquel Raynal miquel.raynal at bootlin.com
Mon Oct 16 20:28:13 AEDT 2023

On Sun, 2023-10-08 at 20:01:29 UTC, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.


More information about the Linuxppc-dev mailing list