[PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

Athira Rajeev atrajeev at linux.vnet.ibm.com
Fri Oct 13 02:47:28 AEDT 2023



> On 05-Oct-2023, at 9:15 PM, David Laight <David.Laight at ACULAB.COM> wrote:
> 
> From: David Laight
>> Sent: 05 October 2023 11:16
> ...
>>> - cs_etm_path=$(find  /sys/bus/event_source/devices/cs_etm/ -name cpu* -print -quit)
>>> + cs_etm_path=$(find  /sys/bus/event_source/devices/cs_etm/ -name 'cpu*' -print -quit)
>> 
>> Isn't the intention to get the shell to expand "cpu* ?
>> So quoting it completely breaks the script.
> 
> Complete brain-fade :-(

Hi David,

Yeah, quoting it also will expand

Thanks
Athira
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
> 



More information about the Linuxppc-dev mailing list