[PATCH v3 9/9] efi: move screen_info into efi init code
Catalin Marinas
catalin.marinas at arm.com
Tue Oct 10 20:39:13 AEDT 2023
On Mon, Oct 09, 2023 at 11:18:45PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
>
> After the vga console no longer relies on global screen_info, there are
> only two remaining use cases:
>
> - on the x86 architecture, it is used for multiple boot methods
> (bzImage, EFI, Xen, kexec) to commucate the initial VGA or framebuffer
> settings to a number of device drivers.
>
> - on other architectures, it is only used as part of the EFI stub,
> and only for the three sysfb framebuffers (simpledrm, simplefb, efifb).
>
> Remove the duplicate data structure definitions by moving it into the
> efi-init.c file that sets it up initially for the EFI case, leaving x86
> as an exception that retains its own definition for non-EFI boots.
>
> The added #ifdefs here are optional, I added them to further limit the
> reach of screen_info to configurations that have at least one of the
> users enabled.
>
> Reviewed-by: Ard Biesheuvel <ardb at kernel.org>
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
> Acked-by: Helge Deller <deller at gmx.de>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
> arch/arm/kernel/setup.c | 4 ----
> arch/arm64/kernel/efi.c | 4 ----
> arch/arm64/kernel/image-vars.h | 2 ++
It's more Ard's thing and he reviewed it already but if you need another
ack:
Acked-by: Catalin Marinas <catalin.marinas at arm.com>
More information about the Linuxppc-dev
mailing list