[Bisected] [commit 2ad56efa80db] [Hotplug] WARNING while performing hotplug operation on 6.6-rc3-next

[Tasmiya Nalatwad]

Greetings,

Thanks Jason.

The fix provided by you works. It is not giving WARNING's but i am 
seeing below logs. Would you please confirm on the logs.

https://lore.kernel.org/all/0-v1-2b52423411b9+164fc-iommu_ppc_defdomain_jgg@nvidia.com/

[  152.342125] pci 0013:60:00.0: No hypervisor support for SR-IOV on 
this device, IOV BARs disabled.
[  152.344896] pci 0013:60:00.0: PME# supported from D0 D3hot D3cold
[  152.348936] pci 0013:60:00.0: Adding to iommu group 0
[  152.349944] pci 0013:60:00.1: No hypervisor support for SR-IOV on 
this device, IOV BARs disabled.
[  152.352701] pci 0013:60:00.1: PME# supported from D0 D3hot D3cold
[  152.356520] pci 0013:60:00.1: Adding to iommu group 0
[  152.356527] iommu_tce: it_map is not empty
[  152.357501] pci 0013:60:00.2: No hypervisor support for SR-IOV on 
this device, IOV BARs disabled.
[  152.360247] pci 0013:60:00.2: PME# supported from D0 D3hot D3cold
[  152.364070] pci 0013:60:00.2: Adding to iommu group 0
[  152.364075] *iommu_tce: it_map is not empty*
[  152.365043] pci 0013:60:00.3: No hypervisor support for SR-IOV on 
this device, IOV BARs disabled.
[  152.367790] pci 0013:60:00.3: PME# supported from D0 D3hot D3cold
[  152.371635] pci 0013:60:00.3: Adding to iommu group 0
[  152.371641] iommu_tce: it_map is not empty
[  152.371720] pci 0013:60:00.0: of_irq_parse_pci: no interrupt-map 
found, INTx interrupts not available
[  152.408351] tg3 0013:60:00.0: iommu: 64-bit OK but direct DMA is 
limited by 800002000000000
[  152.408376] tg3 0013:60:00.0: iommu: 64-bit OK but direct DMA is 
limited by 800002000000000
*[  152.408404] tg3 0013:60:00.0: DMA engine test failed, aborting**
**[  152.408557] tg3: probe of 0013:60:00.0 failed with error -12*
[  152.408583] pci 0013:60:00.1: Adding to iommu group 0
[  152.408589] iommu_tce: it_map is not empty
[  152.408656] pci 0013:60:00.1: of_irq_parse_pci: no interrupt-map 
found, INTx interrupts not available
[  152.448321] tg3 0013:60:00.1: iommu: 64-bit OK but direct DMA is 
limited by 800002000000000
[  152.448339] tg3 0013:60:00.1: iommu: 64-bit OK but direct DMA is 
limited by 800002000000000
[  152.448360] tg3 0013:60:00.1: DMA engine test failed, aborting
[  152.448497] tg3: probe of 0013:60:00.1 failed with error -12
[  152.448519] pci 0013:60:00.2: Adding to iommu group 0
[  152.448525] iommu_tce: it_map is not empty
[  152.448586] pci 0013:60:00.2: of_irq_parse_pci: no interrupt-map 
found, INTx interrupts not available
[  152.488323] tg3 0013:60:00.2: iommu: 64-bit OK but direct DMA is 
limited by 800002000000000
[  152.488340] tg3 0013:60:00.2: iommu: 64-bit OK but direct DMA is 
limited by 800002000000000
[  152.488362] tg3 0013:60:00.2: DMA engine test failed, aborting
[  152.488495] tg3: probe of 0013:60:00.2 failed with error -12
[  152.488516] pci 0013:60:00.3: Adding to iommu group 0
[  152.488523] iommu_tce: it_map is not empty
[  152.488581] pci 0013:60:00.3: of_irq_parse_pci: no interrupt-map 
found, INTx interrupts not available
[  152.528342] tg3 0013:60:00.3: iommu: 64-bit OK but direct DMA is 
limited by 800002000000000
[  152.528359] tg3 0013:60:00.3: iommu: 64-bit OK but direct DMA is 
limited by 800002000000000
[  152.528381] tg3 0013:60:00.3: DMA engine test failed, aborting
[  152.528515] tg3: probe of 0013:60:00.3 failed with error -12

On 10/6/23 17:06, Jason Gunthorpe wrote:
> On Fri, Oct 06, 2023 at 01:20:17PM +0530, Tasmiya Nalatwad wrote:
>> Greetings,
>>
>> [linux-next] [6.6.0-rc3-next-20230929] WARNING: CPU: 5 PID: 185612 at
>> drivers/iommu/iommu.c:3049  iommu_setup_default_domain+0x410/0x680
>>
>> --- Traces ---
>>
>> [ 6296.425934] WARNING: CPU: 5 PID: 185612 at drivers/iommu/iommu.c:3049
>> iommu_setup_default_domain+0x410/0x680
> Does this fix it too? I think it should?
>
> https://lore.kernel.org/r/0-v1-2b52423411b9+164fc-iommu_ppc_defdomain_jgg@nvidia.com
>
> Jason

-- 
Regards,
Tasmiya Nalatwad
IBM Linux Technology Center
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20231006/b40339b5/attachment-0001.htm>