[PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

Athira Rajeev atrajeev at linux.vnet.ibm.com
Wed Nov 29 16:22:34 AEDT 2023



> On 27-Nov-2023, at 8:21 PM, Arnaldo Carvalho de Melo <acme at kernel.org> wrote:
> 
> Em Mon, Nov 27, 2023 at 11:12:57AM +0000, James Clark escreveu:
>> On 23/11/2023 16:02, Athira Rajeev wrote:
>>> Add rule in new Makefile "tests/Makefile.tests" for running
>>> shellcheck on shell test scripts. This automates below shellcheck
>>> into the build.
> 
>> Seems to work really well. I also tested it on Ubuntu, and checked
>> NO_SHELLCHECK, cleaning and with and without shellcheck installed etc.
> 
>> Reviewed-by: James Clark <james.clark at arm.com>
> 
> Tested on Fedora 38, works as advertised, applied.
> 
> - Arnaldo

Hi James, Arnaldo

Thanks for testing the patch and comments.

Athira Rajeev


More information about the Linuxppc-dev mailing list