[PATCH 1/1] arch:hexagon/powerpc: use KSYM_NAME_LEN in array size

Miguel Ojeda miguel.ojeda.sandonis at gmail.com
Mon May 29 20:45:02 AEST 2023

On Mon, May 29, 2023 at 7:44 AM Maninder Singh <maninder1.s at samsung.com> wrote:
> kallsyms_lookup which in turn calls for kallsyms_lookup_buildid()
> writes on index "KSYM_NAME_LEN - 1".
> Thus array size should be KSYM_NAME_LEN.
> for powerpc and hexagon it was defined as "128" directly.
> and commit '61968dbc2d5d' changed define value to 512,
> So both were missed to update with new size.
> Fixes: 61968dbc2d5d ("kallsyms: increase maximum kernel symbol length to 512")
> Signed-off-by: Onkarnath <onkarnath.1 at samsung.com>
> Signed-off-by: Maninder Singh <maninder1.s at samsung.com>

Thanks for this!

There is no `From:` at the top. Since I cannot locate the patch in
Lore, did you mean to put both of you as authors perhaps? In that
case, please use a `Co-developed-by` as needed.

Perhaps it is a good idea to submit each arch independently, too.

The changes themselves look fine on a quick inspection, though the
`xmon.c` one is a global buffer (and there is another equally-sized
buffer in `xmon.c` with a hard-coded `128` constant that would be nice
to clarify).


More information about the Linuxppc-dev mailing list