[PATCH] scsi: ibmvscsi: Replace all non-returning strlcpy with strscpy

Kees Cook keescook at chromium.org
Thu May 18 05:14:04 AEST 2023

On Wed, May 17, 2023 at 02:34:09PM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
> Signed-off-by: Azeem Shaikh <azeemshaikh38 at gmail.com>

Reviewed-by: Kees Cook <keescook at chromium.org>

Kees Cook

More information about the Linuxppc-dev mailing list