[PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver

Vinod Koul vkoul at kernel.org
Tue May 16 23:36:38 AEST 2023


On 08-05-23, 11:28, Sean Anderson wrote:
> On 5/8/23 05:22, Vinod Koul wrote:
> > On 13-04-23, 12:05, Sean Anderson wrote:

> >> +static const struct lynx_cfg ls1088a_cfg = {
> >> +	.lanes = 4,
> >> +	.endian = REGMAP_ENDIAN_LITTLE,
> >> +	.mode_conflict = lynx_ls_mode_conflict,
> >> +	.mode_apply = lynx_ls_mode_apply,
> >> +	.mode_init = lynx_ls_mode_init,
> > 
> > So you have cfg with mode_xxx pointing to same functions for both of the
> > versions you support... so question is why do this and not call the
> > functions directly?
> 
> The intention is to make it easy to add support for T-series processors,
> which have a different PCCR layout.

And when is that going to come. I would prefer this to be added when we
have users being added

-- 
~Vinod


More information about the Linuxppc-dev mailing list