[PATCH net-next 0/9] net: freescale: Convert to platform remove callback returning void

Madalin Bucur madalin.bucur at nxp.com
Mon Mar 13 22:15:00 AEDT 2023


> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Sent: 13 March 2023 12:37
> To: Madalin Bucur <madalin.bucur at nxp.com>; David S. Miller
> <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>; Jakub Kicinski
> <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Russell King
> <linux at armlinux.org.uk>; Wei Fang <wei.fang at nxp.com>; Wolfram Sang
> <wsa at kernel.org>; Chris Packham <chris.packham at alliedtelesis.co.nz>; Andy
> Shevchenko <andriy.shevchenko at linux.intel.com>; Damien Le Moal
> <damien.lemoal at opensource.wdc.com>; Christophe Leroy
> <christophe.leroy at csgroup.eu>; Michael Ellerman <mpe at ellerman.id.au>;
> Mark Brown <broonie at kernel.org>; Marc Kleine-Budde <mkl at pengutronix.de>;
> Pantelis Antoniou <pantelis.antoniou at gmail.com>; Claudiu Manoil
> <claudiu.manoil at nxp.com>; Leo Li <leoyang.li at nxp.com>
> Cc: netdev at vger.kernel.org; kernel at pengutronix.de; Shenwei Wang
> <shenwei.wang at nxp.com>; Clark Wang <xiaoning.wang at nxp.com>; dl-linux-imx
> <linux-imx at nxp.com>; linuxppc-dev at lists.ozlabs.org
> Subject: [PATCH net-next 0/9] net: freescale: Convert to platform remove
> callback returning void
> 
> Hello,
> 
> this patch set converts the platform drivers below
> drivers/net/ethernet/freescale to the .remove_new() callback. Compared to
> the
> traditional .remove() this one returns void. This is a good thing because
> the
> driver core (mostly) ignores the return value and still removes the
> device
> binding. This is part of a bigger effort to convert all 2000+ platform
> drivers to this new callback to eventually change .remove() itself to
> return void.
> 
> The first two patches here are preparation, the following patches
> actually convert the drivers.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (9):
>   net: dpaa: Improve error reporting
>   net: fec: Don't return early on error in .remove()
>   net: dpaa: Convert to platform remove callback returning void
>   net: fec: Convert to platform remove callback returning void
>   net: fman: Convert to platform remove callback returning void
>   net: fs_enet: Convert to platform remove callback returning void
>   net: fsl_pq_mdio: Convert to platform remove callback returning void
>   net: gianfar: Convert to platform remove callback returning void
>   net: ucc_geth: Convert to platform remove callback returning void
> 
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c        |  8 ++++----
>  drivers/net/ethernet/freescale/fec_main.c             | 11 ++++-------
>  drivers/net/ethernet/freescale/fec_mpc52xx.c          |  6 ++----
>  drivers/net/ethernet/freescale/fec_mpc52xx_phy.c      |  6 ++----
>  drivers/net/ethernet/freescale/fman/mac.c             |  5 ++---
>  drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c |  5 ++---
>  drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c  |  6 ++----
>  drivers/net/ethernet/freescale/fs_enet/mii-fec.c      |  6 ++----
>  drivers/net/ethernet/freescale/fsl_pq_mdio.c          |  6 ++----
>  drivers/net/ethernet/freescale/gianfar.c              |  6 ++----
>  drivers/net/ethernet/freescale/ucc_geth.c             |  6 ++----
>  11 files changed, 26 insertions(+), 45 deletions(-)
> 
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> --
> 2.39.1

For the FMan and DPAA drivers,

Acked-by: Madalin Bucur <madalin.bucur at oss.nxp.com>


More information about the Linuxppc-dev mailing list