[PATCH 0/6] bus: fsl-mc: Make remove function return void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Sat Mar 11 09:41:22 AEDT 2023


Hello,

many bus remove functions return an integer which is a historic
misdesign that makes driver authors assume that there is some kind of
error handling in the upper layers. This is wrong however and returning
and error code only yields an error message.

This series improves the fsl-mc bus by changing the remove callback to
return no value instead. As a preparation all drivers are changed to
return zero before so that they don't trigger the error message.

Best regards
Uwe

Uwe Kleine-König (6):
  bus: fsl-mc: Only warn once about errors on device unbind
  bus: fsl-mc: dprc: Push down error message from fsl_mc_driver_remove()
  bus: fsl-mc: fsl-mc-allocator: Drop if block with always wrong
    condition
  bus: fsl-mc: fsl-mc-allocator: Improve error reporting
  soc: fsl: dpio: Suppress duplicated error reporting on device remove
  bus: fsl-mc: Make remove function return void

 drivers/bus/fsl-mc/dprc-driver.c              | 12 ++++-----
 drivers/bus/fsl-mc/fsl-mc-allocator.c         | 27 ++++++++++---------
 drivers/bus/fsl-mc/fsl-mc-bus.c               |  7 +----
 drivers/crypto/caam/caamalg_qi2.c             |  4 +--
 drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c       |  4 +--
 .../net/ethernet/freescale/dpaa2/dpaa2-eth.c  |  4 +--
 .../net/ethernet/freescale/dpaa2/dpaa2-ptp.c  |  4 +--
 .../ethernet/freescale/dpaa2/dpaa2-switch.c   |  4 +--
 drivers/soc/fsl/dpio/dpio-driver.c            |  8 +-----
 drivers/vfio/fsl-mc/vfio_fsl_mc.c             |  3 +--
 include/linux/fsl/mc.h                        |  2 +-
 11 files changed, 28 insertions(+), 51 deletions(-)


base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
-- 
2.39.1



More information about the Linuxppc-dev mailing list