[PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM

[Shengjiu Wang]

On Mon, May 22, 2023 at 6:57 AM Randy Dunlap <rdunlap at infradead.org> wrote:

> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
> so the 2 former symbols should also depend on PPC_BESTCOMM since
> "select" does not follow any dependency chains.
>
> This prevents a kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
>   Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] &&
> SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n]
>   Selected by [m]:
>   - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] &&
> SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]
>   - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] &&
> SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y]
>
> ERROR: modpost: "mpc5200_audio_dma_destroy"
> [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
> ERROR: modpost: "mpc5200_audio_dma_create"
> [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
>
> Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric
> drivers")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Grant Likely <grant.likely at secretlab.ca>
> Cc: Mark Brown <broonie at kernel.org>
> Cc: Liam Girdwood <lgirdwood at gmail.com>
> Cc: Shengjiu Wang <shengjiu.wang at gmail.com>
> Cc: Xiubo Li <Xiubo.Lee at gmail.com>
> Cc: alsa-devel at alsa-project.org
> Cc: linuxppc-dev at lists.ozlabs.org
> Cc: Jaroslav Kysela <perex at perex.cz>
> Cc: Takashi Iwai <tiwai at suse.com>
>

Acked-by: Shengjiu Wang <shengjiu.wang at gmail.com>

Best regards
Wang shengjiu

> ---
> v2: use correct email address for Mark Brown.
>
>  sound/soc/fsl/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
>
>  config SND_MPC52xx_SOC_PCM030
>         tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
> -       depends on PPC_MPC5200_SIMPLE
> +       depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM
>         select SND_SOC_MPC5200_AC97
>         select SND_SOC_WM9712
>         help
> @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030
>
>  config SND_MPC52xx_SOC_EFIKA
>         tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
> -       depends on PPC_EFIKA
> +       depends on PPC_EFIKA && PPC_BESTCOMM
>         select SND_SOC_MPC5200_AC97
>         select SND_SOC_STAC9766
>         help
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20230625/39b86185/attachment-0001.htm>