[RFC PATCH 2/3] powerpc/pci: Remove MVE code

Michael Ellerman mpe at ellerman.id.au
Tue Jun 20 23:16:19 AEST 2023


Joel Stanley <joel at jms.id.au> writes:
> With IODA1 support gone the OPAL calls to set MVE are dead code. Remove
> them.
>
> TODO: Do we have rules for removing unused OPAL APIs? Should we leave it
> in opal.h? opal-call.c?

I don't think we have any rules for removal.

When skiboot was being actively developed Stewart and I did try to keep
the skiboot and kernel opal-api.h in sync, but I haven't checked on the
state of that for a few years. ... And I just checked and boy they are
*not* in sync anymore.

But anyway opal.h and opal-call.c are just kernel internal, so I think
we just remove unused code there as normal.

cheers


More information about the Linuxppc-dev mailing list