[PATCH net-next v2 8/8] net: ucc_geth: Convert to platform remove callback returning void

Simon Horman simon.horman at corigine.com
Thu Jun 8 00:36:59 AEST 2023

On Tue, Jun 06, 2023 at 06:28:29PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> Reviewed-by: Michal Kubiak <michal.kubiak at intel.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Simon Horman <simon.horman at corigine.com>

More information about the Linuxppc-dev mailing list