[PATCH v2 RESEND] soc/fsl/qe: fix usb.c build errors

Leo Li leoyang.li at nxp.com
Thu Jun 1 01:58:25 AEST 2023

> -----Original Message-----
> From: Randy Dunlap <rdunlap at infradead.org>
> Sent: Sunday, May 21, 2023 5:52 PM
> To: linux-kernel at vger.kernel.org
> Cc: Randy Dunlap <rdunlap at infradead.org>; kernel test robot
> <lkp at intel.com>; Michael Ellerman <mpe at ellerman.id.au>; Christophe
> Leroy <christophe.leroy at csgroup.eu>; Leo Li <leoyang.li at nxp.com>;
> Masahiro Yamada <masahiroy at kernel.org>; Nicolas Schier
> <nicolas at fjasle.eu>; Qiang Zhao <qiang.zhao at nxp.com>; linuxppc-dev
> <linuxppc-dev at lists.ozlabs.org>; linux-arm-kernel at lists.infradead.org;
> Kumar Gala <galak at kernel.crashing.org>
> Subject: [PATCH v2 RESEND] soc/fsl/qe: fix usb.c build errors
> Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set.
> This happens when PPC_EP88XC is set, which selects CPM1 & CPM.
> When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE being set.
> When USB_FSL_QE is set, QE_USB deafults to y, which causes build errors
> when QUICC_ENGINE is not set. Making QE_USB depend on QUICC_ENGINE
> prevents QE_USB from defaulting to y.
> Fixes these build errors:
> drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set':
> usb.c:(.text+0x1e): undefined reference to `qe_immr'
> powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr'
> powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg'
> powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock'
> powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock'
> Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Reported-by: kernel test robot <lkp at intel.com>
> Link:
> https://lore.k/
> ernel.org%2Fall%2F202301101500.pillNv6R-
> lkp%40intel.com%2F&data=05%7C01%7Cleoyang.li%40nxp.com%7Ca43927d9
> 554b4434845608db5a4e0db5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%
> 7C0%7C638203063513512722%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7
> C%7C%7C&sdata=LkLi6lS%2Fh3pVXW%2Bg9fauCWmptC9lRt3sTdkvn0Extqk%
> 3D&reserved=0
> Suggested-by: Michael Ellerman <mpe at ellerman.id.au>
> Cc: Christophe Leroy <christophe.leroy at csgroup.eu>
> Cc: Leo Li <leoyang.li at nxp.com>
> Cc: Masahiro Yamada <masahiroy at kernel.org>
> Cc: Nicolas Schier <nicolas at fjasle.eu>
> Cc: Qiang Zhao <qiang.zhao at nxp.com>
> Cc: linuxppc-dev <linuxppc-dev at lists.ozlabs.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Kumar Gala <galak at kernel.crashing.org>

Applied for next.  Thanks.


More information about the Linuxppc-dev mailing list