[PATCH v2] powerpc:platforms:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()

[王明-软件底层技术部]

在 2023/7/12 10:52, Wang Ming 写道:
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. Most incorrect error checks were fixed,
> but the one in scom_debug_init() was forgotten, the other one in
> scom_debug_init_one() was also forgotten.
>
> Fix the remaining error check.
>
> Signed-off-by: Wang Ming <machel at vivo.com>
>
> Fixes: bfd2f0d49aef ("powerpc/powernv: Get rid of old scom_controller abstraction")
> ---
>   arch/powerpc/platforms/powernv/opal-xscom.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c b/arch/powerpc/platforms/powernv/opal-xscom.c
> index 6b4eed2ef4fa..262cd6fac907 100644
> --- a/arch/powerpc/platforms/powernv/opal-xscom.c
> +++ b/arch/powerpc/platforms/powernv/opal-xscom.c
> @@ -168,7 +168,7 @@ static int scom_debug_init_one(struct dentry *root, struct device_node *dn,
>   	ent->path.size = strlen((char *)ent->path.data);
>   
>   	dir = debugfs_create_dir(ent->name, root);
> -	if (!dir) {
> +	if (IS_ERR(dir)) {
>   		kfree(ent->path.data);
>   		kfree(ent);
>   		return -1;
> @@ -190,7 +190,7 @@ static int scom_debug_init(void)
>   		return 0;
>   
>   	root = debugfs_create_dir("scom", arch_debugfs_dir);
> -	if (!root)
> +	if (IS_ERR(root))
>   		return -1;
>   
>   	rc = 0;

hi

This patch has not received any reply so far, please check it

ping: https://lore.kernel.org/all/20230712025250.6512-1-machel@vivo.com/