[PATCH v4 05/13] mm: Add __HAVE_ARCH_PUD_SAME similar to __HAVE_ARCH_P4D_SAME

Christophe Leroy christophe.leroy at csgroup.eu
Tue Jul 11 03:29:47 AEST 2023



Le 10/07/2023 à 18:08, Aneesh Kumar K.V a écrit :
> This helps architectures to override pmd_same and pud_same independently.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.ibm.com>

Reviewed-by: Christophe Leroy <christophe.leroy at csgroup.eu>

Shouldn't you do it the modern way and use #ifndef pud_same instead of a 
new __HAVE_ARCH_PUD_SAME like in the old days ?

> ---
>   include/linux/pgtable.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index 6fd9b2831338..91def34f7784 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -693,7 +693,9 @@ static inline int pmd_same(pmd_t pmd_a, pmd_t pmd_b)
>   {
>   	return pmd_val(pmd_a) == pmd_val(pmd_b);
>   }
> +#endif
>   
> +#ifndef __HAVE_ARCH_PUD_SAME
>   static inline int pud_same(pud_t pud_a, pud_t pud_b)
>   {
>   	return pud_val(pud_a) == pud_val(pud_b);


More information about the Linuxppc-dev mailing list