[PATCH] powerpc/kexec_file: account hot-pluggable memory while estimating FDT size

Sourabh Jain sourabhjain at linux.ibm.com
Mon Jan 30 15:49:36 AEDT 2023


On 30/01/23 08:34, Michael Ellerman wrote:
> Sourabh Jain <sourabhjain at linux.ibm.com> writes:
>> On Systems where online memory is lesser compared to max memory, the
>> kexec_file_load system call may fail to load the kdump kernel with the
>> below errors:
>>
>>      "Failed to update fdt with linux,drconf-usable-memory property"
>>      "Error setting up usable-memory property for kdump kernel"
>>
>> This happens because the size estimation for usable memory properties
>> for the kdump kernel's FDT is based on the online memory whereas the
>> usable memory properties include max memory. In short, the hot-pluggable
>> memory is not accounted for while estimating the size of the usable
>> memory properties.
>>
>> The issue is addressed by calculating usable memory property size using
>> max hotplug address instead of the last online memory address.
>>
>> Fixes: 2377c92e37fe ("powerpc/kexec_file: fix FDT size estimation for kdump kernel")
>> Signed-off-by: Sourabh Jain <sourabhjain at linux.ibm.com>
>> ---
>>   arch/powerpc/kexec/file_load_64.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Can you please rebase it on top of the fix I posted.
>
> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230130014707.541110-1-mpe@ellerman.id.au/
Sure I will rebase it and send the next version.

Thanks,
Sourabh


More information about the Linuxppc-dev mailing list