[PATCH v2 1/2] powerpc/ps3: Change updateboltedpp panic to info

Christophe Leroy christophe.leroy at csgroup.eu
Tue Jan 10 04:41:14 AEDT 2023



Le 03/01/2023 à 18:51, Geoff Levand a écrit :
> Commit fdacae8a84024474afff234bdd1dbe19ad597a10 (powerpc: Activate
> CONFIG_STRICT_KERNEL_RWX by default) causes ps3_hpte_updateboltedpp()
> to be called.  Change the panic statment in ps3_hpte_updateboltedpp()
> to a pr_info statement so that bootup can continue.

But if I understand correctly, it means that CONFIG_STRICT_KERNEL_RWX 
won't work then.

So, shouldn't we keep the panic and forbid CONFIG_STRICT_KERNEL_RWX on PS3 ?


> 
> Signed-off-by: Geoff Levand <geoff at infradead.org>
> ---
>   arch/powerpc/platforms/ps3/htab.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/ps3/htab.c b/arch/powerpc/platforms/ps3/htab.c
> index c27e6cf85272..9de62bd52650 100644
> --- a/arch/powerpc/platforms/ps3/htab.c
> +++ b/arch/powerpc/platforms/ps3/htab.c
> @@ -146,7 +146,7 @@ static long ps3_hpte_updatepp(unsigned long slot, unsigned long newpp,
>   static void ps3_hpte_updateboltedpp(unsigned long newpp, unsigned long ea,
>   	int psize, int ssize)
>   {
> -	panic("ps3_hpte_updateboltedpp() not implemented");
> +	pr_info("ps3_hpte_updateboltedpp() not implemented");
>   }
>   
>   static void ps3_hpte_invalidate(unsigned long slot, unsigned long vpn,


More information about the Linuxppc-dev mailing list