[PATCH] macintosh/macio-adb: add missing iounmap() on error in macio_init()

Yang Yingliang yangyingliang at huawei.com
Thu Jan 5 17:41:45 AEDT 2023


Add missing iounmap(), if request_irq() fails.

Signed-off-by: Yang Yingliang <yangyingliang at huawei.com>
---
 drivers/macintosh/macio-adb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/macintosh/macio-adb.c b/drivers/macintosh/macio-adb.c
index 55a9f8c3a150..779f1268286e 100644
--- a/drivers/macintosh/macio-adb.c
+++ b/drivers/macintosh/macio-adb.c
@@ -123,6 +123,7 @@ int macio_init(void)
 	irq = irq_of_parse_and_map(adbs, 0);
 	of_node_put(adbs);
 	if (request_irq(irq, macio_adb_interrupt, 0, "ADB", (void *)0)) {
+		iounmap(adb);
 		printk(KERN_ERR "ADB: can't get irq %d\n", irq);
 		return -EAGAIN;
 	}
-- 
2.25.1



More information about the Linuxppc-dev mailing list