[PATCH v1 1/3] powerpc: Fix processing of CONFIG_CMDLINE

Geoff Levand geoff at infradead.org
Wed Jan 4 03:44:54 AEDT 2023


Hi Rob,

On 1/2/23 18:03, Rob Herring wrote:
> On Mon, Jan 2, 2023 at 1:41 PM Geoff Levand <geoff at infradead.org> wrote:

>> --- a/arch/powerpc/kernel/prom.c
>> +++ b/arch/powerpc/kernel/prom.c
>> @@ -761,7 +761,7 @@ void __init early_init_devtree(void *params)
>>         DBG(" -> early_init_devtree(%px)\n", params);
>>
>>         /* Too early to BUG_ON(), do it by hand */
>> -       if (!early_init_dt_verify(params))
>> +       if (!early_init_dt_scan(params))
> 
> It would be nice if this could be used instead, but it does other
> things like memory setup which I think will not work for some PPC
> platforms.

It seems like what we need is to pull out the command line processing
code from early_init_dt_scan_nodes and put that into a new function,
say early_init_setup_cmdline, then have both early_init_dt_scan_nodes
and powerpc's early_init_devtree call early_init_setup_cmdline.

I'll split this series into two, one for the PS3 updates, and one
that adds early_init_setup_cmdline.

-Geoff



More information about the Linuxppc-dev mailing list