[PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC

[Christophe Leroy]

Le 15/02/2023 à 23:44, Leo Li a écrit :
> 
> 
>> -----Original Message-----
>> From: Herve Codina <herve.codina at bootlin.com>
>> Sent: Thursday, January 26, 2023 2:32 AM
>> To: Herve Codina <herve.codina at bootlin.com>; Leo Li
>> <leoyang.li at nxp.com>; Rob Herring <robh+dt at kernel.org>; Krzysztof
>> Kozlowski <krzysztof.kozlowski+dt at linaro.org>; Liam Girdwood
>> <lgirdwood at gmail.com>; Mark Brown <broonie at kernel.org>; Christophe
>> Leroy <christophe.leroy at csgroup.eu>; Michael Ellerman
>> <mpe at ellerman.id.au>; Nicholas Piggin <npiggin at gmail.com>; Qiang Zhao
>> <qiang.zhao at nxp.com>; Jaroslav Kysela <perex at perex.cz>; Takashi Iwai
>> <tiwai at suse.com>; Shengjiu Wang <shengjiu.wang at gmail.com>; Xiubo Li
>> <Xiubo.Lee at gmail.com>; Fabio Estevam <festevam at gmail.com>; Nicolin
>> Chen <nicoleotsuka at gmail.com>
>> Cc: linuxppc-dev at lists.ozlabs.org; linux-arm-kernel at lists.infradead.org;
>> devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; alsa-devel at alsa-
>> project.org; Thomas Petazzoni <thomas.petazzoni at bootlin.com>
>> Subject: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC
> 
> Typo: cpm1
> 
>>
>> The QMC (QUICC Multichannel Controller) emulates up to 64 channels within
>> one serial controller using the same TDM physical interface routed from the
>> TSA.
>>
>> It is available in some	PowerQUICC SoC such as the
>> MPC885 or MPC866.
>>
>> It is also available on some Quicc Engine SoCs.
>> This current version support CPM1 SoCs only and some enhancement are
>> needed to support Quicc Engine SoCs.
>>
>> Signed-off-by: Herve Codina <herve.codina at bootlin.com>
> 
> Otherwise looks good to me.
> 
> Acked-by: Li Yang <leoyang.li at nxp.com>

Thanks for the review and the ack.

Were you also able to have a look at patch 2 which implements support 
for the timeslot assigner (TSA) ?

Christophe