[PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot
    Andrew Donnellan 
    ajd at linux.ibm.com
       
    Mon Feb 13 00:33:17 AEDT 2023
    
    
  
On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote:
> > > +err:
> > > +    kfree(var.data);
> > 
> > remove the kfree()
> 
> Actually don't remove it but it should probably be
> 
> if (var.data != &version)
>      kfree(var.data);
> 
Argh, thanks for catching this.
I don't think the condition is needed - we can assume the var.data is
unmodified.
mpe, are you able to fix this up in merge?
-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd at linux.ibm.com   IBM Australia Limited
    
    
More information about the Linuxppc-dev
mailing list