[PATCH 05/22] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return
Josh Poimboeuf
jpoimboe at kernel.org
Sat Feb 4 09:05:14 AEDT 2023
arch_cpu_idle_dead() doesn't return. Make that more explicit with a
BUG().
BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.
Signed-off-by: Josh Poimboeuf <jpoimboe at kernel.org>
---
arch/csky/kernel/smp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/csky/kernel/smp.c b/arch/csky/kernel/smp.c
index b45d1073307f..0ec20efaf5fd 100644
--- a/arch/csky/kernel/smp.c
+++ b/arch/csky/kernel/smp.c
@@ -317,5 +317,7 @@ void arch_cpu_idle_dead(void)
"jmpi csky_start_secondary"
:
: "r" (secondary_stack));
+
+ BUG();
}
#endif
--
2.39.0
More information about the Linuxppc-dev
mailing list