[PATCH] powerpc/hv-24x7: Fix pvr check when setting interface version

Sachin Sant sachinp at linux.ibm.com
Thu Feb 2 01:11:21 AEDT 2023



> On 01-Feb-2023, at 12:18 AM, Kajol Jain <kjain at linux.ibm.com> wrote:
> 
> Commit ec3eb9d941a9 ("powerpc/perf: Use PVR rather than
> oprofile field to determine CPU version") added usage
> of pvr value instead of oprofile field to determine the
> platform. In hv-24x7 pmu driver code, pvr check uses PVR_POWER8
> when assigning the interface version for power8 platform.
> But power8 can also have other pvr values like PVR_POWER8E and
> PVR_POWER8NVL. Hence the interface version won't be set
> properly incase of PVR_POWER8E and PVR_POWER8NVL.
> Fix this issue by adding the checks for PVR_POWER8E and
> PVR_POWER8NVL as well.
> 
> Fixes: ec3eb9d941a9 ("powerpc/perf: Use PVR rather than oprofile field to determine CPU version")
> Reported-by: Sachin Sant <sachinp at linux.ibm.com>
> Signed-off-by: Kajol Jain <kjain at linux.ibm.com>
> ---

Thanks for the fix. Tested on Power8 successfully.
Tested-by: Sachin Sant <sachinp at linux.ibm.com>

> arch/powerpc/perf/hv-24x7.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
> index 33c23225fd54..8c3253df133d 100644
> --- a/arch/powerpc/perf/hv-24x7.c
> +++ b/arch/powerpc/perf/hv-24x7.c
> @@ -1727,7 +1727,8 @@ static int hv_24x7_init(void)
> }
> 
> /* POWER8 only supports v1, while POWER9 only supports v2. */
> - if (PVR_VER(pvr) == PVR_POWER8)
> + if (PVR_VER(pvr) == PVR_POWER8 || PVR_VER(pvr) == PVR_POWER8E ||
> + PVR_VER(pvr) == PVR_POWER8NVL)

Do we really need the check for Power8NV?


More information about the Linuxppc-dev mailing list