[PATCH 2/3] PCI/AER: Decode Requester ID when no error info found
Jonathan Cameron
Jonathan.Cameron at Huawei.com
Sat Dec 9 01:38:02 AEDT 2023
On Wed, 6 Dec 2023 16:42:30 -0600
Bjorn Helgaas <helgaas at kernel.org> wrote:
> From: Bjorn Helgaas <bhelgaas at google.com>
>
> When a device with AER detects an error, it logs error information in its
> own AER Error Status registers. It may send an Error Message to the Root
> Port (RCEC in the case of an RCiEP), which logs the fact that an Error
> Message was received (Root Error Status) and the Requester ID of the
> message source (Error Source Identification).
>
> aer_print_port_info() prints the Requester ID from the Root Port Error
> Source in the usual Linux "bb:dd.f" format, but when find_source_device()
> finds no error details in the hierarchy below the Root Port, it printed the
> raw Requester ID without decoding it.
>
> Decode the Requester ID in the usual Linux format so it matches other
> messages.
>
> Sample message changes:
>
> - pcieport 0000:00:1c.5: AER: Correctable error received: 0000:00:1c.5
> - pcieport 0000:00:1c.5: AER: can't find device of ID00e5
> + pcieport 0000:00:1c.5: AER: Correctable error message received from 0000:00:1c.5
> + pcieport 0000:00:1c.5: AER: found no error details for 0000:00:1c.5
>
> Signed-off-by: Bjorn Helgaas <bhelgaas at google.com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>
More information about the Linuxppc-dev
mailing list